Skip to content

feat: add keyboard shortcut reference panel#908

Open
Prashant-kumar-8312 wants to merge 2 commits into
magic-peach:mainfrom
Prashant-kumar-8312:feat/shortcut-key-panel
Open

feat: add keyboard shortcut reference panel#908
Prashant-kumar-8312 wants to merge 2 commits into
magic-peach:mainfrom
Prashant-kumar-8312:feat/shortcut-key-panel

Conversation

@Prashant-kumar-8312
Copy link
Copy Markdown

Description

Added a keyboard shortcut help panel to improve shortcut discoverability in the video editor.

Changes made:

Created KeyboardShortcutPanel.tsx
Added a ? help button in the editor UI
Added keyboard shortcut toggle using the ? key

Added modal/drawer UI listing all supported shortcuts:
Cmd/Ctrl + Enter → Start export
Space → Play / pause preview
? → Toggle shortcut panel
Escape → Close overlay / cancel
Integrated panel into VideoEditor.tsx
Added keyboard handler updates in useVideoEditor.ts

Related Issue

Closes #655

Type of Contribution

  • Bug fix
  • New feature
  • Documentation update
  • GSSoC contribution

Participant Info

  • GitHub username: @Prashant-kumar-8312
  • Contribution level (Beginner/Intermediate/Advanced): Beginner

Screenshot

Screenshot 2026-05-22 125222 Screenshot 2026-05-22 125244

Screen Recording

Reframe.Resize.trim.and.export.videos.in.your.browser.-.Google.Chrome.2026-05-22.01-33-47_compressed.mp4

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue
  • Screen recording attached above (required for UI/feature/design changes)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

@Prashant-kumar-8312 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @Prashant-kumar-8312!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2026

✅ PR Format Check Passed — @Prashant-kumar-8312

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added gssoc'26 GirlScript Summer of Code 2026 level:advanced Advanced level - 55 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature labels May 22, 2026
@magic-peach magic-peach added type:accessibility Accessibility and removed type:bug Bug fix type:docs Documentation type:design UI/UX design labels May 24, 2026
@magic-peach magic-peach mentioned this pull request May 24, 2026
13 tasks
@magic-peach
Copy link
Copy Markdown
Owner

@Prashant-kumar-8312 This PR adds a useful keyboard shortcut reference panel. However:

  1. No build/lint/typecheck CI has run — the PR has only label/validate checks. Please push an update to trigger full CI.

  2. Merge conflicts with main — please rebase on the latest main and resolve conflicts.

  3. Overlap with PR #897 keyboard shortcuts added #902 — PR #897 keyboard shortcuts added #902 also includes a keyboard shortcuts help modal as part of a larger keyboard shortcuts implementation. After both have CI passing, we'll review and merge the better implementation. If #897 keyboard shortcuts added #902 merges first, please check for overlap.

Steps:

git fetch upstream
git rebase upstream/main
git push --force-with-lease origin feat/shortcut-key-panel

Once rebased and CI passes, this will be reviewed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:advanced Advanced level - 55 pts type:accessibility Accessibility type:feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: keyboard shortcut reference panel — show all shortcuts in a discoverable overlay

2 participants